Fixed data for the dsl #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 64 64
Lines 4756 4789 +33
=======================================
+ Hits 4727 4760 +33
Misses 29 29 ☔ View full report in Codecov by Sentry. |
|
This is nice, I think very useful as I imagine people might have pre-analysis tasks that generate hyperparameters, and this seems like a great way to pass them into the dsl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @edknock, this allows fixed data to be inserted into the DSL code.
This can be reviewed directly, or look at #79 first and then rebase to get a smaller diff. However, the fallout is not so bad either way